RFR: 8340092: [Linux] containers/systemd/SystemdMemoryAwarenessTest.java failing on some systems [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Sep 16 14:19:05 UTC 2024


On Mon, 16 Sep 2024 14:16:19 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this trivial test fix. The test fails if the `<slice>.d` directory already exists (for some reason). It needs to exist for the test to work. But if it exists we ignore the failure, thus using `Files.createDirectories()`.
>> 
>> As a benefit I've also added `exclusiveAccess.dirs=.` to the `systemd` test directory to match container tests in `docker` folder and added `TRUNCATE_EXISTING` and `CREATE` open options for files in the `<slice>.d` directory. Both of which should ensure the test runs more reliably.
>> 
>> Testing:
>> - [ ] GHA
>> - [x] Manual testing by creating the directory first, running the test. Failed. The same handshake passes after the patch.
>> 
>> Thanks!
>
> Severin Gehwolf has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Cleanup files when systemd --user fails
>  - Skip test if systemd user manager not properly working
>  - Add CREATE open option.

I don't know what needs to happen for `systemctl --user status` to work correctly for all (possible) sessions. Therefore, I'm skipping the test when run as user and `systemctl --user daemon-reload` fails. I've added comments to https://bugs.openjdk.org/browse/JDK-8333446 and https://bugs.openjdk.org/browse/JDK-8340092

@MBaesken Please try the latest version. Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20989#issuecomment-2353056034


More information about the hotspot-runtime-dev mailing list