RFR: 8298614: Support CDS heap dumping for non-G1 collectors [v2]

[David Holmes]

On Tue, 17 Sep 2024 16:53:31 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/cds/heapShared.cpp line 469:
>> 
>>> 467:                                         p2i((address)G1CollectedHeap::heap()->reserved().start()),
>>> 468:                     UseCompressedOops ? p2i(CompressedOops::end()) :
>>> 469:                                         p2i((address)G1CollectedHeap::heap()->reserved().end()));
>> 
>> Does this work if you build a minimal VM with only SerialGC? I would expect the build to fail.
>
> Yes, I verified locally that this works on a minimal build

Doh! Of course it does. The minimal VM doesn't have CDS either. Sorry.

If you build explicitly without G1 then I would expect this to fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1764018370