RFR: 8339192: Native annotation parsing code of deprecated annotations causes crash [v2]

David Holmes dholmes at openjdk.org
Tue Sep 17 22:10:04 UTC 2024


On Tue, 17 Sep 2024 07:06:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Also I'm not clear what encoding you are envisaging as the "normal" C based encoding would be zero == false and anything else is true - but that doesn't map to  using `& 1`.
>
> Ah now I see what JVMS is specifying: only look at the LSB to determine true or false.

I think in this case we can assume/expect a valid annotation generated by javac and so check for `== 1`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21030#discussion_r1764078621


More information about the hotspot-runtime-dev mailing list