RFR: 8298614: Support CDS heap dumping for SerialGC and ParallelGC [v2]

[Matias Saavedra Silva]

On Tue, 17 Sep 2024 23:28:36 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   David and Ioi comments
>
> test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/SharedStringsHumongous.java line 30:
> 
>> 28:  * @comment -- the following implies that G1 is used (by command-line or by default)
>> 29:  * @requires vm.cds.write.archived.java.heap
>> 30:  * @requires vm.flagless
> 
> Shouldn't 
>  @requires vm.gc.G1
> works better here if only G1 is supported?

This is a direct upstream from Leyden which uses `@requires vm.flagless` although I think you're right.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21004#discussion_r1765459870