RFR: 8339460: CDS error when module is located in a directory with space in the name [v2]

[Ioi Lam]

On Tue, 24 Sep 2024 06:20:55 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> The crux of the problem is that path names in CDS are saved as URIs and subsequently "converted" back to path names simply by stripping off the prefix without appropriate conversion of the rest of the name. This commit adds such a conversion.
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improved the test and excluded it from hotspot_appcds_dynamic

Looks good. Some small nits.

src/hotspot/share/classfile/classLoader.cpp line 1260:

> 1258: #ifdef _WINDOWS
> 1259:     if (uri[0] == '/') {
> 1260:         // Absolute path name on Windows does not begin with a slash

Please use 2-space indents.

src/hotspot/share/classfile/classLoader.cpp line 1272:

> 1270:             decoded = '\\';
> 1271:         }
> 1272: #endif

Is this necessary for this patch? If not, I think we should not include it, since it changes behavior (i.e., strcmp() on the path may start failing).

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20987#pullrequestreview-2326753890
PR Review Comment: https://git.openjdk.org/jdk/pull/20987#discussion_r1774262698
PR Review Comment: https://git.openjdk.org/jdk/pull/20987#discussion_r1774262474