RFR: 8339460: CDS error when module is located in a directory with space in the name [v2]

[Maxim Kartashev]

On Wed, 25 Sep 2024 00:50:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improved the test and excluded it from hotspot_appcds_dynamic
>
> src/hotspot/share/classfile/classLoader.cpp line 1260:
> 
>> 1258: #ifdef _WINDOWS
>> 1259:     if (uri[0] == '/') {
>> 1260:         // Absolute path name on Windows does not begin with a slash
> 
> Please use 2-space indents.

Certainly. Done.

> Is this necessary for this patch?

I suppose, not. Let me check that the test still passes on Windows, though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20987#discussion_r1774855793
PR Review Comment: https://git.openjdk.org/jdk/pull/20987#discussion_r1774856829