RFR: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path [v3]

[David Holmes]

On Tue, 25 Mar 2025 09:15:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Noticed this while removing OM counters. When doing [JDK-8351187](https://bugs.openjdk.org/browse/JDK-8351187), I apparently forgot to cover a path from `ObjectSynchronizer::quick_notify`, probably due to concurrent renames. I think we can cover this gap while still simplifying the code: let `ObjectMonitor` handle all events, DTrace, JFR, OM stats.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 server fastdebug, `jdk_jfr`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge branch 'master' into JDK-8352256-quick-notify-jfr
>  - Review comment
>  - Fix

Changes requested by dholmes (Reviewer).

src/hotspot/share/runtime/objectMonitor.hpp line 388:

> 386:   void      notifyAll(TRAPS);
> 387:   void      quick_notify(TRAPS);
> 388:   void      quick_notifyAll(TRAPS);

These should not be declared with TRAPS as they don't throw exceptions (and must not!). These should simply take a `JavaThread* current` parameter.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24097#pullrequestreview-2745291465
PR Review Comment: https://git.openjdk.org/jdk/pull/24097#discussion_r2030287303