RFR: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path [v3]
Aleksey Shipilev
shade at openjdk.org
Mon Apr 7 08:04:08 UTC 2025
On Sun, 6 Apr 2025 22:20:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into JDK-8352256-quick-notify-jfr
>> - Review comment
>> - Fix
>
> src/hotspot/share/runtime/objectMonitor.hpp line 388:
>
>> 386: void notifyAll(TRAPS);
>> 387: void quick_notify(TRAPS);
>> 388: void quick_notifyAll(TRAPS);
>
> These should not be declared with TRAPS as they don't throw exceptions (and must not!). These should simply take a `JavaThread* current` parameter.
Makes sense, fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24097#discussion_r2030668190
More information about the hotspot-runtime-dev
mailing list