RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v8]

Afshin Zafari azafari at openjdk.org
Tue Apr 8 08:15:29 UTC 2025


On Mon, 7 Apr 2025 17:54:33 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixes. New check_tree impl and visualization.
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 790:
> 
>> 788:     }
>> 789: 
>> 790:     sprintf(for_this_node, "test at line: %d, for node: %d", line_no, et.nodes[i]);
> 
> I see `warning: 'sprintf' is deprecated:...use snprintf(3) instead` on macOS when I try to run the gtest locally.

Good catch. Forgotten to do so.
Changed to `snprintf` now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2032648220


More information about the hotspot-runtime-dev mailing list