RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v8]

[Gerard Ziemski]

On Mon, 7 Apr 2025 12:37:30 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> In NMT detail mode, we need to have separate call-stacks for Reserve and Commit operations.
>> This PR adds a second stack to every node that will be used when committing (and uncommitting) the start node of a reserved region.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixes. New check_tree impl and visualization.

Changes requested by gziemski (Reviewer).

test/hotspot/gtest/nmt/test_vmatree.cpp line 790:

> 788:     }
> 789: 
> 790:     sprintf(for_this_node, "test at line: %d, for node: %d", line_no, et.nodes[i]);

I see `warning: 'sprintf' is deprecated:...use snprintf(3) instead` on macOS when I try to run the gtest locally.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24028#pullrequestreview-2747629382
PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2031728184