RFR: 8352568: Test gtest/AsyncLogGtest.java failed at droppingMessage_vm

[Matthias Baesken]

On Tue, 8 Apr 2025 12:41:58 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> The test for dropping messages have started to fail on aarch64 fast debug on Linux only when run as part of a test group. This seems to be a multi-threading issue with the `BufferUpdater`. When the `BufferUpdater` is removed, the issue disappears. This PR changes the code in a few other ways as well:
> 
> 1. Fail if the asynchronous mode isn't "drop" (the test makes no sense with stalling mode)
> 2. Print the entirety of the log file produced if no missing messages are found
> 3. If the thread running the test is unattached, then async UL will emit log messages in synchronous mode. Therefore, if the thread is unattached, the test now fails with an error message.
> 
> If the test fails in the future, then these will give important diagnostic information regarding the state of the test.
> 
> This is a re-worked version of https://github.com/openjdk/jdk/pull/24411

Looks okay and no issues seen in our CI ; small comment inside

test/hotspot/gtest/logging/test_asynclog.cpp line 250:

> 248:   if (AsyncLogWriter::instance() == nullptr) return;
> 249:   if (LogConfiguration::async_mode() != LogConfiguration::AsyncMode::Drop) {
> 250:     EXPECT_TRUE(false) << "This test must be run in drop mode if async UL is activated";

EXPECT_TRUE(false) looks a little weird but probably does what you want;  could you just use FAIL() here ?

-------------

Marked as reviewed by mbaesken (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24508#pullrequestreview-2771451846
PR Review Comment: https://git.openjdk.org/jdk/pull/24508#discussion_r2046266776