RFR: 8352568: Test gtest/AsyncLogGtest.java failed at droppingMessage_vm [v2]

[Johan Sjölen]

On Wed, 16 Apr 2025 07:29:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use FAIL
>
> test/hotspot/gtest/logging/test_asynclog.cpp line 250:
> 
>> 248:   if (AsyncLogWriter::instance() == nullptr) return;
>> 249:   if (LogConfiguration::async_mode() != LogConfiguration::AsyncMode::Drop) {
>> 250:     EXPECT_TRUE(false) << "This test must be run in drop mode if async UL is activated";
> 
> EXPECT_TRUE(false) looks a little weird but probably does what you want;  could you just use FAIL() here ?

Oh, nice, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24508#discussion_r2046321392