RFR: 8298733: Reconsider monitors_on_stack assert [v2]

[Fredrik Bredberg]

On Wed, 16 Apr 2025 17:09:40 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated after Patricio's review
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 578:
> 
>> 576:   StackWatermark* watermark = StackWatermarkSet::get(thread, StackWatermarkKind::gc);
>> 577:   for (frame f = thread->last_frame(); Continuation::is_frame_in_continuation(ce, f); f = f.sender(&map)) {
>> 578:     if (watermark != nullptr) {
> 
> I meant also this nullptr check which can be done outside the loop. You could move it at the beginning of this method and just return if watermark is null.

But of course. It's fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24655#discussion_r2053945330