RFR: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java [v2]

[David Holmes]

On Tue, 22 Apr 2025 09:46:16 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Rewrote the test  runtime/LoadClass/LoadClassNegative so that it creates an empty jar file on the fly and then removes it. Previously existing dummy.jar removed.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8354327: Renamed the empty jar file.

test/hotspot/jtreg/runtime/LoadClass/LoadClassNegative.java line 46:

> 44:     // Create an empty file in the scratch directory
> 45:     final String filename = "empty.jar";
> 46:     File dummyFile = new File(filename);

Suggestion:

    File emptyJar = new File("empty.jar");

and then use `emptyJar` throughout.

test/hotspot/jtreg/runtime/LoadClass/LoadClassNegative.java line 59:

> 57:     output.shouldContain("ClassNotFoundException");
> 58:     output.shouldHaveExitValue(0);
> 59: 

No need to add an extra blank line here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24688#discussion_r2055315948
PR Review Comment: https://git.openjdk.org/jdk/pull/24688#discussion_r2055316799