RFR: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java [v2]

[Anton Artemov]

On Wed, 23 Apr 2025 06:10:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8354327: Renamed the empty jar file.
>
> test/hotspot/jtreg/runtime/LoadClass/LoadClassNegative.java line 46:
> 
>> 44:     // Create an empty file in the scratch directory
>> 45:     final String filename = "empty.jar";
>> 46:     File dummyFile = new File(filename);
> 
> Suggestion:
> 
>     File emptyJar = new File("empty.jar");
> 
> and then use `emptyJar` throughout.

Thanks, addressed in the latest commit.

> test/hotspot/jtreg/runtime/LoadClass/LoadClassNegative.java line 59:
> 
>> 57:     output.shouldContain("ClassNotFoundException");
>> 58:     output.shouldHaveExitValue(0);
>> 59: 
> 
> No need to add an extra blank line here.

Thanks, addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24688#discussion_r2057919116
PR Review Comment: https://git.openjdk.org/jdk/pull/24688#discussion_r2057919764