RFR: 8354803: ALL_64_BITS is the same across platforms [v3]

Stefan Karlsson stefank at openjdk.org
Wed Apr 23 13:08:42 UTC 2025


On Wed, 23 Apr 2025 13:04:45 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use a const all_bits_jlong
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 300:
> 
>> 298: const jlong max_jlong = CONST64(0x7fffffffffffffff);
>> 299: 
>> 300: // for timer info max values which include all bits, was CONST64(0x7fffffffffffffff);
> 
> Suggestion:
> 
> // for timer info max values which include all bits, was CONST64(0xffffffffffffffff);

Or just remove the `was CONST64` part since people can find this in git history.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24715#discussion_r2056013438


More information about the hotspot-runtime-dev mailing list