RFR: 8354803: ALL_64_BITS is the same across platforms [v3]

[Stefan Karlsson]

On Wed, 23 Apr 2025 13:04:06 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We have quite a lot of duplication of ALL_64_BITS
>> #define ALL_64_BITS CONST64(0xFFFFFFFFFFFFFFFF)
>> across posix platforms but it is the same for these platforms so it could be moved to a central place.
>> 
>> On Windows it is currently
>> #define ALL_64_BITS CONST64(-1)
>> but this should be the same too.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use a const all_bits_jlong

Looks good, but there's a slight error in the comment

src/hotspot/share/utilities/globalDefinitions.hpp line 300:

> 298: const jlong max_jlong = CONST64(0x7fffffffffffffff);
> 299: 
> 300: // for timer info max values which include all bits, was CONST64(0x7fffffffffffffff);

Suggestion:

// for timer info max values which include all bits, was CONST64(0xffffffffffffffff);

-------------

PR Review: https://git.openjdk.org/jdk/pull/24715#pullrequestreview-2787231780
PR Review Comment: https://git.openjdk.org/jdk/pull/24715#discussion_r2056011108