RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v2]

[Coleen Phillimore]

On Fri, 25 Apr 2025 12:24:08 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Rewrote JsrRewriting and OomWhileParsingRepeatedJsr tests so that are not using jar files, but instead class files are created on the fly using the the ASM library. 
>> 
>> Test in tiers 1-3 on multiple platforms pass.
>
> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8354329: Addressed the reviewer's comments, refactored 2nd test.
>  - 8354329: Fixed whitespaces errors.
>  - 8354329: Refactored out jasm file for JsrRewriting, added dumper class.
>  - Merge remote-tracking branch 'origin/master' into JDK-8354329
>  - 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests

Yes this looks good for one test.  Hopefully the other can be similarly modified.

test/hotspot/jtreg/runtime/ClassFile/JsrRewriting.java line 37:

> 35:  * @requires vm.flagless
> 36:  * @library /test/lib
> 37:  * @library /testlibrary/asm

This file should change the copyright to look like:

 * Copyright (c) 2011, 2025, Oracle and/or its affiliates. All rights reserved.

test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 1:

> 1: import org.objectweb.asm.AnnotationVisitor;

This needs the copyright header.  See the one in the java file for an example.  The copyright should be just 2025 for this file since it's new.  The copyright for the other file should be changed to include 2025 as the end date.  Note the strange looking trailing comments.

test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 49:

> 47:             methodVisitor.visitInsn(RETURN);
> 48: 
> 49: 

In this extra line, can you add a comment that this is the line that overflows the jump target for the jsr?

-------------

PR Review: https://git.openjdk.org/jdk/pull/24662#pullrequestreview-2792128373
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2059005132
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2059004135
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2059009929