RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v2]

[Anton Artemov]

On Thu, 24 Apr 2025 18:23:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - 8354329: Addressed the reviewer's comments, refactored 2nd test.
>>  - 8354329: Fixed whitespaces errors.
>>  - 8354329: Refactored out jasm file for JsrRewriting, added dumper class.
>>  - Merge remote-tracking branch 'origin/master' into JDK-8354329
>>  - 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests
>
> test/hotspot/jtreg/runtime/ClassFile/JsrRewriting.java line 37:
> 
>> 35:  * @requires vm.flagless
>> 36:  * @library /test/lib
>> 37:  * @library /testlibrary/asm
> 
> This file should change the copyright to look like:
> 
>  * Copyright (c) 2011, 2025, Oracle and/or its affiliates. All rights reserved.

Addressed in the latest commit.

> test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 1:
> 
>> 1: import org.objectweb.asm.AnnotationVisitor;
> 
> This needs the copyright header.  See the one in the java file for an example.  The copyright should be just 2025 for this file since it's new.  The copyright for the other file should be changed to include 2025 as the end date.  Note the strange looking trailing comments.

Addressed in the latest commit.

> test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 49:
> 
>> 47:             methodVisitor.visitInsn(RETURN);
>> 48: 
>> 49: 
> 
> In this extra line, can you add a comment that this is the line that overflows the jump target for the jsr?

Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2060140389
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2060140884
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2060139458