RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v2]

[Anton Artemov]

On Fri, 25 Apr 2025 14:05:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - 8354329: Addressed the reviewer's comments, refactored 2nd test.
>>  - 8354329: Fixed whitespaces errors.
>>  - 8354329: Refactored out jasm file for JsrRewriting, added dumper class.
>>  - Merge remote-tracking branch 'origin/master' into JDK-8354329
>>  - 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests
>
> test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 52:
> 
>> 50:         AnnotationVisitor annotationVisitor0;
>> 51: 
>> 52:         classWriter.visit(V1_1, ACC_PUBLIC | ACC_SUPER, "OOMCrashClass4000_1", null, "java/applet/Applet", null);
> 
> David said that this Applet class is going away.  Will this test work if you change it to java/lang/String maybe?  Or some other class?

No for String, when you change all occurrences  java/applet/Applet -> java/lang/String, it means you inherit from String, but String is a final class. Same for any other final class. However, for java/lang/Object, it works. Addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2060401507