RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 25 14:07:52 UTC 2025


On Fri, 25 Apr 2025 12:27:13 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Rewrote JsrRewriting and OomWhileParsingRepeatedJsr tests so that are not using jar files, but instead class files are created on the fly using the the ASM library. 
>> 
>> Test in tiers 1-3 on multiple platforms pass.
>
> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8354329: Addressed the reviewer's comments, refactored 2nd test.
>  - 8354329: Fixed whitespaces errors.
>  - 8354329: Refactored out jasm file for JsrRewriting, added dumper class.
>  - Merge remote-tracking branch 'origin/master' into JDK-8354329
>  - 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests

test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 52:

> 50:         AnnotationVisitor annotationVisitor0;
> 51: 
> 52:         classWriter.visit(V1_1, ACC_PUBLIC | ACC_SUPER, "OOMCrashClass4000_1", null, "java/applet/Applet", null);

David said that this Applet class is going away.  Will this test work if you change it to java/lang/String maybe?  Or some other class?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2060311494


More information about the hotspot-runtime-dev mailing list