RFR: 8349755: Fix corner case issues in async UL [v7]

David Holmes dholmes at openjdk.org
Wed Feb 12 08:46:15 UTC 2025


On Wed, 12 Feb 2025 08:22:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use -Xlog:all=debug for entering the deathtest message
>
> test/hotspot/jtreg/runtime/logging/AsyncDeathTestDebug.java line 42:
> 
>> 40:     public static void main(String[] args) throws Exception {
>> 41:         ProcessBuilder pb =
>> 42:             ProcessTools.createLimitedTestJavaProcessBuilder("-Xlog:async", "-Xlog:all=debug");
> 
> If we are going to crash we should add `-XX:-CreateCoredumpOnCrash`

Also does this mean we are going to crash on the very first log_debug? You have two logging statements that will trigger the crash but only one of them can be reached with the way the testing is structured.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1952187695


More information about the hotspot-runtime-dev mailing list