RFR: 8349755: Fix corner case issues in async UL [v7]

[Johan Sjölen]

On Wed, 12 Feb 2025 08:26:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/logging/AsyncDeathTestDebug.java line 42:
>> 
>>> 40:     public static void main(String[] args) throws Exception {
>>> 41:         ProcessBuilder pb =
>>> 42:             ProcessTools.createLimitedTestJavaProcessBuilder("-Xlog:async", "-Xlog:all=debug");
>> 
>> If we are going to crash we should add `-XX:-CreateCoredumpOnCrash`
>
> Also does this mean we are going to crash on the very first log_debug? You have two logging statements that will trigger the crash but only one of them can be reached with the way the testing is structured.

You're right, we do crash on the very first log_debug we reach (when in debug mode) as this hits the `ShouldNotReachHere()`. Both can be reached, but when one has been reached the other one won't be reached. I think it's fine, we're simply trying to see whether the recursive logging case is handled correctly.

> If we are going to crash we should add -XX:-CreateCoredumpOnCrash

What's your thinking here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1952561164