RFR: 8349755: Fix corner case issues in async UL [v7]

Johan Sjölen jsjolen at openjdk.org
Wed Feb 12 12:30:27 UTC 2025


On Wed, 12 Feb 2025 08:16:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use -Xlog:all=debug for entering the deathtest message
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 45:
> 
>> 43: 
>> 44:   ~AsyncLogLocker() {
>> 45:     assert(_holder == nullptr || _holder == Thread::current_or_null(), "must be");
> 
> Don't understand this change. We are in the destructor so if the holder is null then this must be an unattached thread. So the original assert suffices.

True, this is an unnecessary change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1952555392


More information about the hotspot-runtime-dev mailing list