RFR: 8349755: Fix corner case issues in async UL [v7]

Johan Sjölen jsjolen at openjdk.org
Thu Feb 13 09:45:10 UTC 2025


On Wed, 12 Feb 2025 23:57:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> You're right, we do crash on the very first log_debug we reach (when in debug mode) as this hits the `ShouldNotReachHere()`. Both can be reached, but when one has been reached the other one won't be reached. I think it's fine, we're simply trying to see whether the recursive logging case is handled correctly.
>> 
>>> If we are going to crash we should add -XX:-CreateCoredumpOnCrash
>> 
>> What's your thinking here?
>
> When a test knows it will crash we don't want to generate a coredump as we don't care about it. Dumping can take a significant time on some systems leading to timeouts.

Thanks David, I missed the `-` and was under the pretension that we don't create coredumps by default :).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23513#discussion_r1954164233


More information about the hotspot-runtime-dev mailing list