RFR: 8350444: Check for verifer error in StackMapReader::check_offset() [v2]

Matias Saavedra Silva matsaave at openjdk.org
Fri Feb 21 16:19:58 UTC 2025


On Thu, 20 Feb 2025 23:02:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This small patch adds error propagation in the newly added `check_offset()` method. Verified with tier 1-5 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check for exception without TRAPS

I think Coleen's analysis is correct, the error is caught by the callers and explains why this made it through testing. Test already exist that check for the exact error message reported by check_offset() and given that they passed, there was no gap in testing that I know of.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23717#issuecomment-2674977969


More information about the hotspot-runtime-dev mailing list