RFR: 8348536: Build fails with extra cflags -DLOG_PLEASE

Kim Barrett kbarrett at openjdk.org
Mon Feb 24 09:46:55 UTC 2025


On Mon, 24 Feb 2025 02:56:04 GMT, SendaoYan <syan at openjdk.org> wrote:

> Lots of gtests attempt to use SIZE_FORMAT. Isn't this just a missing include of globalDefinitions ??

There are no longer definitions of `SIZE_FORMAT` and `SSIZE_FORMAT` in globalDefinitions.hpp.

Presumably the uses being looked at here (which appear to be all of the remaining residue) were overlooked
because they were under conditional compilation that doesn't didn't get tested.

Running `egrep -r "\bS?SIZE_FORMAT\b" .` in src/hotspot gets nothing.  Running it in test/hotspot/gtest finds
the ones being changed by this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23290#issuecomment-2677886782


More information about the hotspot-runtime-dev mailing list