RFR: 8348536: Build fails with extra cflags -DLOG_PLEASE

[Kim Barrett]

On Fri, 24 Jan 2025 06:36:34 GMT, SendaoYan <syan at openjdk.org> wrote:

> make fails with extra flags '-DLOG_PLEASE'

The way that macro is being used, I don't think it's intended to be globally enabled like that.  It's definition is typically
commented or uncommented to provide some additional logging for some tests of interest.  I'm wondering if the places
where it is currently being defined are debugging leftovers that shouldn't have been committed.

For example, I think the LOG_PLEASE and LOG_HERE in runtime/test_os_reserve_between.cpp should either comment
out the LOG_PLEASE definition or just use ordinary logging.  Maybe @tstuefe has an opinion?

Maybe the changes related to LOG_PLEASE definitions ought to be removed and examined as a separate issue?
It's still good that the lingering SIZE_FORMATs were uncovered and are being fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23290#issuecomment-2678001782