RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v2]
Kazuhisa Takakuri
ktakakuri at openjdk.org
Wed Feb 26 07:23:00 UTC 2025
On Wed, 12 Feb 2025 02:34:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>
> test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 66:
>
>> 64:
>> 65: List<String> command = new ArrayList<>();
>> 66: //Execution command to prevent garbled characters
>
> Suggestion:
>
> // Force language to English before running systeminfo to get the OS version
I fixed it.
> test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 69:
>
>> 67: command.addAll(List.of("cmd.exe", "/c", "set", "PATH=%PATH%;C:\\Windows\\System32;C:\\Windows\\System32\\wbem", "&&"));
>> 68: command.addAll(List.of("chcp", "437", ">nul", "2>&1", "&&"));
>> 69: //Execute command to obtain OS Version
>
> Suggestion:
I fixed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r1971061865
PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r1971062120
More information about the hotspot-runtime-dev
mailing list