RFR: 8348028: Unable to run gtests with CDS enabled [v3]

[Calvin Cheung]

On Thu, 27 Feb 2025 05:42:45 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comments
>
> make/hotspot/lib/JvmFeatures.gmk line 36:
> 
>> 34: ################################################################################
>> 35: 
>> 36: JVM_CFLAGS_FEATURES += -DJVM_VARIANT=\"$(JVM_VARIANT)\"
> 
> Might it be a better idea to set -DJVM_VARIANT as the CXXFLAGS for cdsConfig.cpp directly instead?

Currently, os_bsd.cpp also needs the JVM_VARIANT definition. Later, if we fix the `os::jvm_path()` issues, os_windows.cpp, os_linux.cpp and os_aix.cpp also need JVM_VARIANT.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23758#discussion_r1972978001