RFR: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"

[David Holmes]

On Wed, 8 Jan 2025 10:57:09 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> This bug was introduced by [JDK-8252921](https://bugs.openjdk.org/browse/JDK-8252921) which moved the unregister call from the thread destructor (because it was not called for all threads) to the post_run() method. But this totally overlooked native threads that attach and detach! This is easily fixed by moving the unregister call to the end of JavaThread::exit.
>> 
>> We also update the ProblemList and disable -Xcheck:JNI for a test that does actually terminate threads without detaching.
>> 
>> Testing: tiers 1-4
>> 
>> Thanks.
>
> LGTM, thank you for your work on this.

Thanks for the review @jdksjolen !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22924#issuecomment-2578704755