RFR: 8348384: RISC-V: Disable auto-enable Vector on buggy kernels
Hamlin Li
mli at openjdk.org
Thu Jan 23 11:57:52 UTC 2025
On Thu, 23 Jan 2025 09:51:23 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Hi please consider!
>
> Linux kernels pre-6.9 can copy a dirty v-state during signal return path:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/riscv/kernel/signal.c?h=v6.13-rc1&id=c27fa53b858b4ee6552a719aa599c250cf98a586
>
> We should not auto-enable vector with such kernel, as we must be able to receive signals during the execution of vector code.
>
> Manual tested pre and post 6.9 as expected.
>
> Thanks, Robbin
Looks good.
Just a minor comment.
src/hotspot/os_cpu/linux_riscv/riscv_hwprobe.cpp line 173:
> 171: if (!(major > 6 || (major == 6 && minor >= 9))) {
> 172: LogMessage(os) log;
> 173: if (log.is_info()) {
`log_info` could make the code simpler.
-------------
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23256#pullrequestreview-2569667322
PR Review Comment: https://git.openjdk.org/jdk/pull/23256#discussion_r1926860547
More information about the hotspot-runtime-dev
mailing list