RFR: 8348384: RISC-V: Disable auto-enable Vector on buggy kernels

Robbin Ehn rehn at openjdk.org
Thu Jan 23 12:26:51 UTC 2025


On Thu, 23 Jan 2025 11:55:25 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Looks good. Just a minor comment.

Thank you!

> src/hotspot/os_cpu/linux_riscv/riscv_hwprobe.cpp line 173:
> 
>> 171:     if (!(major > 6 || (major == 6 && minor >= 9))) {
>> 172:       LogMessage(os) log;
>> 173:       if (log.is_info()) {
> 
> `log_info` could make the code simpler.

This is a multi-line log therefore I need the LogMessage.
Without it it's not certain they are logged together or with the same decorators.
The log level could even be changed between two log_info so only one of the lines are logged.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23256#issuecomment-2609677102
PR Review Comment: https://git.openjdk.org/jdk/pull/23256#discussion_r1926894064


More information about the hotspot-runtime-dev mailing list