RFR: 8346792: serviceability/jvmti/vthread/GetThreadState/GetThreadState.java testObjectWaitMillis failed [v12]

[Serguei Spitsyn]

On Fri, 31 Jan 2025 04:13:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: add an explaining comment; remove an extra empty line
>
> src/hotspot/share/services/threadService.hpp line 490:
> 
>> 488: 
>> 489:  public:
>> 490:   JavaThreadInObjectWaitState(JavaThread *java_thread, bool timed, bool interruptible) :
> 
> Suggestion:
> 
>   // Sets the java.lang.Thread state of the given JavaThread to reflect it is doing a regular, or timed, Object.wait call.
>   //
>   // The interruptible parameter, if false, indicates an internal uninterruptible wait, in which case we do not
>   // update the java.lang.Thread state. We do that by passing the current state to the JavaThreadStatusChanger
>   // so no actual change is observable, and skip the statistics updates. This avoids having to duplicate code
>   // paths for the interruptible/ and non-interruptible cases in the caller.
>   JavaThreadInObjectWaitState(JavaThread *java_thread, bool timed, bool interruptible) :

Good suggestion, thank you! Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23126#discussion_r1938005031