RFR: 8346792: serviceability/jvmti/vthread/GetThreadState/GetThreadState.java testObjectWaitMillis failed [v12]

[Serguei Spitsyn]

On Fri, 31 Jan 2025 04:23:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: add an explaining comment; remove an extra empty line
>
> src/hotspot/share/services/threadService.hpp line 492:
> 
>> 490:   JavaThreadInObjectWaitState(JavaThread *java_thread, bool timed, bool interruptible) :
>> 491:     JavaThreadStatusChanger(java_thread,
>> 492:                             // This helper should do nothing when interruptible == false, so we set active = false.
> 
> What is `active`??

`active` is `_active`. I've removed this line of comment. It is already a good clarification in your suggestion above.
Setting `_active` to `false` makes it to overpass the calls to:
 `_stat->monitor_wait_begin()` and `_stat->monitor_wait_begin()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23126#discussion_r1938009523