RFR: 8359820: Improve handshake/safepoint timeout diagnostic messages [v3]
Thomas Stuefe
stuefe at openjdk.org
Fri Jul 18 09:43:54 UTC 2025
On Fri, 18 Jul 2025 09:02:38 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> src/hotspot/share/utilities/vmError.cpp line 827:
>>
>>> 825: } else {
>>> 826: st->print(" (sent by kill)");
>>> 827: }
>>
>> I don't understand.
>>
>> Should not the receiving thread be the timeouted thread? So the one that is executing right now?
>
> I think it can be that the receiving thread does not manage to report the error, but `safepointTimedOutThread` already got a value, which could confuse the reporting method of `VMError` called on another thread. I think this check is needed, as pointed out by @dholmes-ora .
You lost me here.
Here we report a SIGILL being received by thread A, sent by thread B. This information is sure.
Do you mean that thread A was not the intended recipient of the SIGILL?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26309#discussion_r2215597682
More information about the hotspot-runtime-dev
mailing list