RFR: 8359959: Test runtime/NMT/VirtualAllocTestType.java failed: '\\[0x[0]*7f7dc4043000 - 0x[0]*7f7dc4083000\\] reserved 256KB for Test' missing from stdout/stderr [v3]

Afshin Zafari azafari at openjdk.org
Thu Jun 19 13:03:02 UTC 2025


On Thu, 19 Jun 2025 12:25:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reviews
>
> test/hotspot/jtreg/runtime/NMT/VirtualAllocTestType.java line 65:
> 
>> 63: 
>> 64:       // If the second mapping happens to be adjacent to the first mapping, reserve another mapping and release the second mapping; for
>> 65:       // this test, we want to see two disjunct mappings.
> 
> The comment no longer seems quite accurate.

Updated.

> test/hotspot/jtreg/runtime/NMT/VirtualAllocTestType.java line 72:
> 
>> 70: 
>> 71:         wb.NMTReleaseMemory(addr1, reserveSize);
>> 72:         wb.NMTReleaseMemory(addr2, reserveSize);
> 
> Just to be clear we are only releasing the original mappings to keep things consistent? And we could do this before reserving the new three region mapping - right?

Not applicable in new approach. PR description is updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25894#discussion_r2156967720
PR Review Comment: https://git.openjdk.org/jdk/pull/25894#discussion_r2156968098


More information about the hotspot-runtime-dev mailing list