RFR: 8350584: Check the usage of LOG_PLEASE

[Thomas Stuefe]

On Tue, 25 Feb 2025 10:41:12 GMT, SendaoYan <syan at openjdk.org> wrote:

> Having debug logging enabled in some tests is not necessarily an issue that needs to be "fixed". You need to ask the person who enabled it why they did so.
> 
> If it is enabled in some tests then we do need to guard against redefinition incase it is globally enabled (and there is nothing wrong with that either).

That.

Yes, these are mine. I tend to introduce them when I think I may have to look at a failing gtest again, possibly on some weird platform. If people are bothered by it, we can remove the output, but I think they are still slightly useful in their current form. I never actually thought people would globally define the log.

Using UL logging may not work as intended since UL may not be available in some gtests.

While debug output is not bad, it's better to disable it by default, since we need to take care that the output does not overflow and get truncated by the jtreg runner.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23764#issuecomment-2693320728