RFR: 8356407: Part of class verification is skipped in AOT training run [v2]

[Matias Saavedra Silva]

On Wed, 7 May 2025 20:35:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp comments
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 765:
> 
>> 763: //     true:  is_reference_assignable_from() should SKIP the assignability check
>> 764: //     false: is_reference_assignable_from() should COMPLETE the assignability check
>> 765: void SystemDictionaryShared::add_verification_constraint(InstanceKlass* k, Symbol* name,
> 
> Why did you change the type of the return variable?

I second this, why can't you return skip_assignability_check here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25104#discussion_r2078538209