RFR: 8356407: Part of class verification is skipped in AOT training run [v2]

[Ioi Lam]

On Wed, 7 May 2025 21:44:42 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionaryShared.cpp line 765:
>> 
>>> 763: //     true:  is_reference_assignable_from() should SKIP the assignability check
>>> 764: //     false: is_reference_assignable_from() should COMPLETE the assignability check
>>> 765: void SystemDictionaryShared::add_verification_constraint(InstanceKlass* k, Symbol* name,
>> 
>> Why did you change the type of the return variable?
>
> I second this, why can't you return skip_assignability_check here?

I changed the code because a `bool` return, without spelling out what it actually means, is hard to understand, especially on the side of the caller.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25104#discussion_r2078543074