RFR: 8356407: Part of class verification is skipped in AOT training run [v2]

[Ioi Lam]

On Wed, 7 May 2025 20:38:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp comments
>
> src/hotspot/share/classfile/verificationType.cpp line 111:
> 
>> 109: #if INCLUDE_CDS
>> 110:     if (CDSConfig::is_dumping_archive()) {
>> 111:       bool skip_assignability_check;
> 
> I think you have to assign this to false in case add_verification_constraint() doesn't set the value, something you don't know at the call site.  I guess the return value is worse than a return parameter because false seems to indicate that the call didn't add a verification constraint.  But I think this should be initialized just in case.

I added the assignment as you suggested. The reason I used a separate variable is to make the code and the comment easier to understand.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25104#discussion_r2078539580