RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v14]
Igor Veresov
iveresov at openjdk.org
Tue May 13 03:34:54 UTC 2025
On Mon, 12 May 2025 17:13:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/share/cds/filemap.cpp line 1955:
>
>> 1953: " does not equal the current SpecTrapLimitExtraEntries setting (%d).", file_type,
>> 1954: _spec_trap_limit_extra_entries, SpecTrapLimitExtraEntries);
>> 1955: return false;
>
> The `log_info(cds)` should be replaced with `MetaspaceShared::report_loading_error`. (The few `log_info` lines above this block will be fixed in [JDK-8356807](https://bugs.openjdk.org/browse/JDK-8356807))
>
> Also, could you add a new jtreg test case for this? You can see examples in `negativeTests` in the existing AOTFlags.java test case. I think you can add your checks into the new AOTProfileFlags.java test.
Do you want me to leave the existing `log_info` alone? Or should I fix everything in `FileMapHeader::validate()` ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2085858973
More information about the hotspot-runtime-dev
mailing list