RFR: 8356233: NMT: tty->print_cr should not be used in VirtualMemoryTracker::add_reserved_region()

Gerard Ziemski gziemski at openjdk.org
Mon May 19 20:23:27 UTC 2025


To help with debugging NMT we added more info when an assert gets triggered, but we used `tty`, which is involved with locks and unfortunately it triggered:


# Internal Error (.../open/src/hotspot/share/runtime/mutex.cpp:457), pid=1088443, tid=1088520
# assert(false) failed: Attempting to acquire lock tty_lock/tty out of order with lock NmtVirtualMemory_lock/service-4 -- possible deadlock


We avoid this, by printing using `UL` instead of using `tty` directly.

-------------

Commit messages:
 - revert debug change
 - revert header change
 - convert to UL

Changes: https://git.openjdk.org/jdk/pull/25308/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25308&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8356233
  Stats: 15 lines in 1 file changed: 6 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/25308.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25308/head:pull/25308

PR: https://git.openjdk.org/jdk/pull/25308


More information about the hotspot-runtime-dev mailing list