RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v29]

[Afshin Zafari]

On Wed, 21 May 2025 22:28:21 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed a missed change in test.
>
> test/hotspot/gtest/nmt/test_vmatree.cpp line 318:
> 
>> 316:   Tree tree;
>> 317:   VMATree::RegionData rd1(si[0], mtTest);
>> 318:   VMATree::RegionData rd2(si[1], mtNone);
> 
> We keep using those later in and it is hard to keep track of what `rd1` is. I suggest we use better names for those, such as `rd_Test`, then I know what mem_tag that region uses without having to go back.
> 
> I renamed other instances, like `call_stack_2` as well.
> 
> I have changed lots of those and here is a diff file with this change: [gerard.diff.zip](https://github.com/user-attachments/files/20376150/gerard.diff.zip)

Unfortunately, your patch couldn't be applied, since it cannot find some expected text in my local code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2102017148