RFR: 8357408: runtime/interpreter/CountBytecodesTest.java should be flagless [v2]
Aleksey Shipilev
shade at openjdk.org
Mon May 26 09:07:31 UTC 2025
On Sat, 24 May 2025 05:28:45 GMT, Lei Zhu <duke at openjdk.org> wrote:
>> I changed `@requires` to `vm.flagless` and it passed the test. If there is anything inappropriate, please let me know and I will modify it in time.
>
> Lei Zhu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> 8357408: runtime/interpreter/CountBytecodesTest.java should be flagless
Yes, it should be `vm.flagless`, since it runs in driver mode with `executeLimitedTestJava`. But it should also remain `vm.debug & vm.bits == "64"`, because `CountBytecodes` option is `develop` (so it is not available in release builds), and the counter would likely overflow in 32-bit modes ([JDK-8350642](https://bugs.openjdk.org/browse/JDK-8350642) made the counter 64-bit only for 64-bit platforms).
So just add `@requires vm.flagless`, leaving the other `@requires` alone.
Run the test with both fastdebug and release builds to confirm it still works.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25427#pullrequestreview-2867754154
More information about the hotspot-runtime-dev
mailing list