RFR: 8357408: runtime/interpreter/CountBytecodesTest.java should be flagless [v2]
Lei Zhu
duke at openjdk.org
Tue May 27 08:42:50 UTC 2025
On Mon, 26 May 2025 09:00:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Yes, it should be `vm.flagless`, since it runs in driver mode with `executeLimitedTestJava`. But it should also remain `vm.debug & vm.bits == "64"`, because `CountBytecodes` option is `develop` (so it is not available in release builds), and the counter would likely overflow in 32-bit modes ([JDK-8350642](https://bugs.openjdk.org/browse/JDK-8350642) made the counter 64-bit only for 64-bit platforms).
>
> So just add `@requires vm.flagless`, leaving the other `@requires` alone.
>
> Run the test with both fastdebug and release builds to confirm it still works.
Thank you for your correction. I have modified it and it has passed the test. Please review it again.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25427#issuecomment-2911676670
More information about the hotspot-runtime-dev
mailing list