RFR: 8365526: Crash with null Symbol passed to SystemDictionary::resolve_or_null [v5]

[Johan Sjölen]

On Mon, 24 Nov 2025 19:31:42 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use put_when_absent and add an assert that the message is the same.
>
> src/hotspot/share/classfile/resolutionErrors.cpp line 76:
> 
>> 74:   ResolutionErrorKey key(pool(), cp_index);
>> 75:   ResolutionErrorEntry *entry = new ResolutionErrorEntry(error, message, cause, cause_msg);
>> 76:   _resolution_error_table->put(key, entry);
> 
> This is surely leaking the ResolutionErrorEntry if the key is already present?

This was meant to comment your new code, not the old code... Same with the other comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28438#discussion_r2557497236