RFR: 8365526: Crash with null Symbol passed to SystemDictionary::resolve_or_null [v5]
Johan Sjölen
jsjolen at openjdk.org
Mon Nov 24 20:38:09 UTC 2025
On Mon, 24 Nov 2025 19:33:25 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/hotspot/share/classfile/resolutionErrors.cpp line 76:
>>
>>> 74: ResolutionErrorKey key(pool(), cp_index);
>>> 75: ResolutionErrorEntry *entry = new ResolutionErrorEntry(error, message, cause, cause_msg);
>>> 76: _resolution_error_table->put(key, entry);
>>
>> This is surely leaking the ResolutionErrorEntry if the key is already present?
>
> This was meant to comment your new code, not the old code... Same with the other comment.
My bad, `put_when_absent` asserts that entry is absent.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28438#discussion_r2557651118
More information about the hotspot-runtime-dev
mailing list