RFR: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter

Paul Hübner phubner at openjdk.org
Fri Sep 12 08:14:27 UTC 2025


On Tue, 2 Sep 2025 07:07:51 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This PR adds the missing locks for the tests and MemMapPrinter, also fixes a small bug in `walk_virtual_memory`. See inline review comments.
> 
> Passes tier1.

src/hotspot/share/nmt/memTracker.hpp line 176:

> 174:   }
> 175: 
> 176:   static inline bool walk_virtual_memory(VirtualMemoryWalker* walker) {

Nit: should probably be in `memTracker.inline.hpp`?

src/hotspot/share/nmt/memTracker.hpp line 183:

> 181:   }
> 182: 
> 183:   static inline MemoryFileTracker::MemoryFile* register_file(const char* descriptive_name) {

Same here. I wonder why we have the inline header when it only contains `MemTracker::check_exceeds_limit`...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343359401
PR Review Comment: https://git.openjdk.org/jdk/pull/27038#discussion_r2343361247


More information about the hotspot-runtime-dev mailing list