<i18n dev> [8] Request for review: 8000245/8000273/8000615

[Masayoshi Okutsu]

The try-catch is no longer needed. Otherwise, the fix looks good to me.

Masayoshi

On 2012/10/15 23:49, Naoto Sato wrote:
> Since CLDR may not have all the defaults on the root bundle, I changed 
> the fix to use ResourceBundle.containsKey() method which guarantees to 
> look for the key including its parent bundles. Also changed 
> OpenListResourceBundle to ResourceBundle, since it is no longer 
> needed. Here is the latest webrev:
>
> http://cr.openjdk.java.net/~naoto/8000245.8000273.8000615/webrev.02/
>
> Naoto
>
> On 10/15/12 12:03 PM, Naoto Sato wrote:
>> Thanks, Masayoshi, for the review. I removed that 'pool'. As to
>> "contains(key)", it has to be removed so that ResourceBundle's fallback
>> should occur with the requested locale. In fact, those try-catch would
>> never be used for normal keys because JRE/CLDR root bundles contain all
>> the defaults.
>>
>> Here is the updated webrev:
>>
>> http://cr.openjdk.java.net/~naoto/8000245.8000273.8000615/webrev.01/
>>
>> Naoto
>> On 10/14/12 12:14 PM, Masayoshi Okutsu wrote:
>>> Here are my comments.
>>>
>>> LocaleNameProvider/CurrencyNameProvider/TimeZoneNameProvider:
>>>
>>> - pool is no longer used and should be removed.
>>>
>>> - Should contains(key) be retained? It should be faster than try-catch.
>>>
>>> Otherwise, the fix looks good to me.
>>>
>>> Thanks,
>>> Masayoshi
>>>
>>> On 10/12/2012 6:45 AM, Naoto Sato wrote:
>>>> Hello,
>>>>
>>>> Please review the changes for the subject bugs:
>>>>
>>>> 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition)
>>>> doesn't work as expected with custom extensions
>>>> 8000273: java.util.Locale.getDisplayVariant(Locale l) isn't
>>>> transferred to the custom service provider
>>>> 8000615: JRE adapter: timezone name of en_US is changed when extension
>>>> directory is added
>>>>
>>>> All of these bugs are regressions caused by the JEP 127 change, where
>>>> locale providers are invoked not with the originally requested locale.
>>>> Now it is invoked with the original locale as in
>>>> LocaleServiceProviderPool.java. With this change, resource bundle
>>>> locale check in JRE's
>>>> LocaleNameProvider/CurrencyNameProvider/TimeZoneNameProvider
>>>> implementations are no longer needed.
>>>>
>>>> The webrev for these changes are located at:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8000245.8000273.8000615/webrev.00/
>>>>
>>>> Naoto
>>>
>>
>